fix(string-prototype): use newer valid definition

Marak / colors.js

get colors in your node.js console

https://github.com/Marak/colors.js

Other

5.16k stars 446 forks source link

fix(string-prototype): use newer valid definition #246

Closed Vheissu closed 5 years ago

Vheissu commented 5 years ago

Object.prototype.defineGetter has been deprecated as per MDN here. I have changed the usage of __defineGetter to use defineProperty - this also fixes an issue I encountered in Karma.

DABH commented 5 years ago

Happy to consider if you can make the CI tests pass... others have tried this change before with no luck but maybe you can be the one who figures this out :)

Vheissu commented 5 years ago

@DABH Legend. Will do and get back to you.