Revert infinite loop bug

Marak / colors.js

get colors in your node.js console

https://github.com/Marak/colors.js

Other

5.16k stars 446 forks source link

Revert infinite loop bug #286

Open EricPKerr opened 2 years ago

EricPKerr commented 2 years ago

This reverts a critical error described here: https://github.com/Marak/colors.js/commit/074a0f8ed0c31c35d13d28632bd8a049ff136fb6

oliviergf commented 2 years ago

LGTM :heavy_check_mark:

EricPKerr commented 2 years ago

I'm unable to merge or npm publish this. Is a maintainer able to do that?

Nivl commented 2 years ago

It won't be merged. The author did this on purpose, it's not a mistake nor a bug. They did similar things on their other packages, such as Faker.js (they removed the source, and push v6.6.6 to NPM that breaks everything).

G2G2G2G commented 2 years ago

Don't merge this, it breaks functionality of the new library and how I use it.