v1.4.2 is broken - Githubissues

dhilt commented 2 years ago

It was released 1 hour ago and broke my tests in the following nice (not) way:

I fixed it in my lib by reverting package-lock.json: https://github.com/dhilt/ngx-ui-scroll/pull/300/commits/dd782fce90217c730419b32c82e86af529752f3a (BTW it is suggested to downgrade to 1.4.0, thanks to @lirantal, so here's another downgrade commit)

I suppose it might relate to destruction of the Faker.js project (5 days ago): https://github.com/Marak/faker.js

Hamahmi commented 2 years ago

It is, check this commit https://github.com/Marak/colors.js/commit/074a0f8ed0c31c35d13d28632bd8a049ff136fb6

floscher commented 2 years ago

See #285

lirantal commented 2 years ago

@dhilt please revert back to using 1.4.0 if you can to mitigate the issue. Versions 1.4.1 and 1.4.2 would both introduce a denial of service upon usage.

dhilt commented 2 years ago

@lirantal Thanks, will do!

Apollon77 commented 2 years ago

@Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!

pxseu commented 2 years ago

@Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!

That's.... the point of why he has done that

dustinlw1987 commented 2 years ago

Marak should NOT be trusted as a developer! Especially after doing this unilaterally without notification.

DABH commented 2 years ago

Please consider closing this issue so that people will go to #285 instead -- trying to keep solutions and updates in one place. Thanks.

dustinlw1987 commented 2 years ago

@Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!

That's.... the point of why he has done that

There is absolutely NO REASON to fuck over people this way! That's how you burn bridges and have people not trust you as an developer.

pxseu commented 2 years ago

I'm not saying what he has done was right but in my opinion he doesn't have to notify someone with a change in his software, you're free to fork it and all

On Mon, Jan 10, 2022, 00:19 Dustin Williams @.***> wrote:

@Marak https://github.com/Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!

That's.... the point of why he has done that

There is absolutely NO REASON to fuck over people this way! That's how you burn bridges and have people not trust you as an developer.

— Reply to this email directly, view it on GitHub https://github.com/Marak/colors.js/issues/289#issuecomment-1008444368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANZJY2P2KJ4R3CEUPCAAID3UVIJXBANCNFSM5LSITCWQ . You are receiving this because you commented.Message ID: <Marak/colors. @.***>

dustinlw1987 commented 2 years ago

Sure, and that is EXACTLY what is happening. Marak is being cut out and deleted as nobody trusts him now.

Apollon77 commented 2 years ago

In my eyes there are two sides right now: 1.) The present and how to fix the real issue ... ideally supporting him that he hopefully reverts latest on npm to 1.4.0 2.) Future: Then the affected libraries can think about movingg away or whatever

I'm interested rigt now in Point 1 ...

shayneoneill commented 2 years ago

"ideally supporting him"

Yeah, no. That would be deeply irresponsible. Not after this. Rewarding this sort of malicious behavior just leads to more of it.

DevXiaolan commented 2 years ago

Did it so

rsadr0pyz commented 2 years ago

npx marak-free

karikera commented 2 years ago

v1.4.1 is also broken v1.4.0 is working

euberdeveloper commented 2 years ago

Hi, in case the author will not maintain this project or fix this, I made a fork that restores the normal behaviour. I am not sure if I will maintain this package, but just in case the problem will not be solved and you don't want to be scared when running npm update...

https://github.com/euberdeveloper/colors.js

In any case I could also suggest passing to the chalk package, which is very good and has a serious and reliable author