search

Marak / colors.js

get colors in your node.js console
https://github.com/Marak/colors.js
Other
5.16k stars 446 forks source link

Fix: liberty liberty zalgo bug #291

Closed YassinEldeeb closed 2 years ago

YassinEldeeb commented 2 years ago

Fixing the intentional liberty zalgo bug by a PR made on a freaking phone.

Fixing: #285 #289 #290

postbird commented 2 years ago

github has disabled marak's account

postbird commented 2 years ago

image

elbojoloco commented 2 years ago

So now that his account is suspended, who can merge this fix?

YassinEldeeb commented 2 years ago

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

postbird commented 2 years ago

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

I have another question, why people use the package not chalk?

YassinEldeeb commented 2 years ago

I have another question, why people use the package not chalk?

I think because latest chalk versions throws an error when using it with Typescript about "Can't use ES6 module in commonjs" and only older versions work with Typescript but colors.js It's no problem.

lnzzz commented 2 years ago

will this fix be merged soon?

YassinEldeeb commented 2 years ago

will this fix be merged soon?

@lnzzz probably no cause this is @Marak revenge for lack of open-source funding, use chalk instead or fork this repo and publish your own working version to npm.

G2G2G2G commented 2 years ago

ah the power of github. You change your package however you want and they disable you.

luislobo commented 2 years ago

Doubt this PR will move forward... but you should also remove ../lib/custom/american

YassinEldeeb commented 2 years ago

Doubt this PR will move forward... but you should also remove ../lib/custom/american

It's a cool art though so I prefer keeping it 😅

Let's just hope this PR gets merged for now and then think about the cool american art.

Awilum commented 2 years ago

Finally!

Awilum commented 2 years ago

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

kleur much better compared to chalk https://www.npmjs.com/package/kleur

BitesizedLion commented 2 years ago

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

kleur much better compared to chalk https://www.npmjs.com/package/kleur

In terms of trustworthiness I trust Chalk wayyyyyyyy more than Kleur or Colors

hello-smile6 commented 2 years ago

will this fix be merged soon?

@lnzzz probably no cause this is @Marak revenge for lack of open-source funding, use chalk instead or fork this repo and publish your own working version to npm.

Someone, JUST GIVE THEM FUNDING!

TechStudent10 commented 2 years ago

@Marak you have claimed your account. Please merge this.

YassinEldeeb commented 2 years ago

Please use chalk or kleur or fork the repo and maintain it yourself.

This won't go forward, this is intentional and there's not a single reason for leaving this PR open cause it's pretty much stale for the rest of life.