search

Marak / colors.js

get colors in your node.js console
https://github.com/Marak/colors.js
Other
5.17k stars 445 forks source link

Improve the name of the variables #314

Open prietales opened 2 years ago

prietales commented 2 years ago

https://github.com/Marak/colors.js/blob/6bc50e79eeaa1d87369bb3e7e608ebed18c5cf26/lib/custom/zalgo.js#L71

What is l?

ethnh commented 2 years ago 
      if (isChar(l)) {
        continue;
      }
      result = result + text[l];

used twice, seems pretty readable to me do you have any suggestions for the name?

prietales commented 2 years ago

https://www.w3.org/wiki/JavaScript_best_practices#Call_things_by_their_name_.E2.80.94_easy.2C_short_and_readable_variable_and_function_names

prietales commented 2 years ago

What is d?

https://github.com/Marak/colors.js/blob/6bc50e79eeaa1d87369bb3e7e608ebed18c5cf26/lib/custom/zalgo.js#L96

richRemer commented 2 years ago

@prietales, you should open a new ticket for the "d" variable. That would be very helpful to keep these important issues separate.

prietales commented 2 years ago

The project is dead.