search

Marak / colors.js

get colors in your node.js console
https://github.com/Marak/colors.js
Other
5.17k stars 446 forks source link

Use the options when summoning Zalgo #98

Closed jennings closed 9 years ago

jennings commented 9 years ago

The options argument in the zalgo(text,options) function never makes it to the heComes(text,options) function. This PR fixes that.

Marak commented 9 years ago

Nice one!

I'll make minor update for code style and merge.

pksunkara commented 9 years ago

lgtm. Will merge as soon you address my comment.

Marak commented 9 years ago

@pksunkara - If the only change required to land a pull request is a 30 second code style update, just do it yourself.

No point wasting time going back and forth if you can quickly make the change yourself.

pksunkara commented 9 years ago

I like to give them a chance first. I will wait 2 days and if they haven't done it, I will do it myself.

Marak commented 9 years ago

I'm telling you to just do it, and in the future, just do it.

Time is precious.

pksunkara commented 9 years ago

Cherry-picked these into develop branch.

pksunkara commented 9 years ago

Merged this.