Open SergKhram opened 1 month ago
Thanks for submitting this @SergKhram
The idea is solid, I think it needs a little bit more work on the handling the number of files as well as the file naming. Your assumption about needing only 1 character holds true only if there are less than 10 video files. Supporting this feature means that marathon should handle even more than that, so likely the trimming should happen the same way as it does for other files to fit into the max file name length
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.93%. Comparing base (
27ee994
) to head (4ab20e1
). Report is 39 commits behind head on develop.:exclamation: Current head 4ab20e1 differs from pull request most recent head 9f22612
Please upload reports for the commit 9f22612 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
https://github.com/MarathonLabs/marathon/issues/796 As mentioned there I prepared the solution If apiLevel >= 34 -> we use time from VideoConfiguration else -> we divide to 180sec videos if timeLimit > 180