search

MarathonLabs / marathon

Cross-platform test runner
https://docs.marathonlabs.io
GNU General Public License v2.0
584 stars 121 forks source link

feat(apple): pulling xcresult policy #945

Closed vfadc closed 5 months ago

vfadc commented 5 months ago

Add pulling xcresult policy. not sure which one would be better, ON_FAILURE or ON_BATCH_FAILURE, anyway, open for rework

matzuk commented 5 months ago

Nice job guys! I just want to emphasize that there is another setting related to artifacts left after an iOS run: Attachment lifetime. The example is:

  xcresult:
    pull: true
    remoteClean: true
    attachments:
      systemAttachmentLifetime: DELETE_ON_SUCCESS
      userAttachmentLifetime: DELETE_ON_SUCCESS

Marathon "passes" these params to xcodebuild to define desired attachments left after a run. I guess it makes sense to describe these params and their impact in more details in the documentation.

vfadc commented 5 months ago

Nice job guys! I just want to emphasize that there is another setting related to artifacts left after an iOS run: Attachment lifetime. The example is:

  xcresult:
    pull: true
    remoteClean: true
    attachments:
      systemAttachmentLifetime: DELETE_ON_SUCCESS
      userAttachmentLifetime: DELETE_ON_SUCCESS

Marathon "passes" these params to xcodebuild to define desired attachments left after a run. I guess it makes sense to describe these params and their impact in more details in the documentation.

Sure, but these changes don't impact on attachments lifetime, attachment-lifetime params are about storing attachments in xcresult files, but pullingPolicy is about pulling xcresult files. So, I can leave a tip in the doc about it.