Maratyszcza / NNPACK

Acceleration package for neural networks on multi-core CPUs
BSD 2-Clause "Simplified" License
1.68k stars 316 forks source link

Feature request: set download dependency root directory #131

Closed dabraude closed 6 years ago

dabraude commented 6 years ago

Would it be possible to set the download directory instead of always being ${CMAKE_BINARY_DIR}/*-download

to something like ${CONFU_DEPENDENCIES_SOURCE_DIR}/*-download don't mind doing it myself if you are happy with that name and CONFU_DEPENDENCIES_SOURCE_DIR defaults to CMAKE_BINARY_DIR

Maratyszcza commented 6 years ago

Did you try to set CONFU_DEPENDENCIES_BINARY_DIR? IIUC, the default download directory is CONFU_DEPENDENCIES_BINARY_DIR/project-name where project name is from cmake/*.cmake

Maratyszcza commented 6 years ago

Correction: the actual download directory is ${CONFU_DEPENDENCIES_SOURCE_DIR}/dependency-name. ${CMAKE_BINARY_DIR}/*-download is a build directory for a CMake project that downloads the dependency.

dabraude commented 6 years ago

Ok is that download project directory necessary after the project has built for the first time? If not the Cmake for MXNet can delete it, otherwise I aiming to put those *-download directories under ${CMAKE_BINARY_DIR}/3rdparty/NNPack/dep/*-download

Maratyszcza commented 6 years ago

It is not necessary, but I think CMake with download dependencies again if it doesn't find expected files in *-download directories

Maratyszcza commented 6 years ago

Would it work for you if *-download files will be in ${CONFU_DEPENDENCIES_BINARY_DIR}/*-download instead of ${CMAKE_BINARY_DIR}/*-download?

dabraude commented 6 years ago

Yeah that would be perfect

Maratyszcza commented 6 years ago

Ok, I will move on with this change. It will take a while as I have to update all NNPACK dependencies.

Maratyszcza commented 6 years ago

Shipped in 04d045a2efe3785edcd7ccc72c2e81dc7a3377c3

dabraude commented 6 years ago

awesome thanks.