Remove -ffast-math compile option, it`s not fully compliant with IEEE or ISO standard.

Maratyszcza / NNPACK

Acceleration package for neural networks on multi-core CPUs

BSD 2-Clause "Simplified" License

1.67k stars 316 forks source link

Remove -ffast-math compile option, it`s not fully compliant with IEEE or ISO standard. #185

Closed Danliran closed 4 years ago

Danliran commented 4 years ago

softmax-output-imagenet-test and softmax-output-smoketest test failed on arm platform. -ffast-math compile option can result in incorrect output for programs that depend on an exact implementation of IEEE or ISO rules/specifications for math functions.

Danliran commented 4 years ago

I presume other architectures might be affected as well. Better disable -ffast-math on all architectures.

good suggestion.