MarcBoule / ImpromptuModular

Virtual Eurorack Modules for VCV Rack
Other
93 stars 10 forks source link

Gateseq: Lock module #34

Closed Eurikon closed 3 years ago

Eurikon commented 3 years ago

Hi Marc, I have been meaning to ask this for a while now. Could you please add a lock for the module (right click context menu?).

I stopped counting the times that accidental clicks while moving around the patch via click grab with mouse, sometimes causes step events to be deleted or added.

This of course is not a bug, but it just can happen. And usually will only happen when being zoomed out, cause that will make the chance bigger for an accidental mouse click to have effect when hovering over the module in a move.

I hope this makes sense :)

MarcBoule commented 3 years ago

I think I follow, but you mean when you click with the middle mouse button? I'm not sure I can reproduce what you are experiencing, since when I middle-click to move the Rack around, it doesn't change the steps in GS64.

Eurikon commented 3 years ago

Hi Marc :)

It happens to me quite often when using a trackpad of the notebook, have not have this happen with a mouse yet.

It also can not be reproduced just like that. Sloppy movements over the screen ,sticky fingers, accidental clicks.. try to reproduce those hehe 🙃

A lock on module level would prevent anything changed on the module itself accidentally, after being happy with its content.

Eurikon commented 3 years ago

If it is too much coding for an issue that can be resolved by switching to song mode, then I understand that as well.

No worries :)

MarcBoule commented 3 years ago

I don't think I will lock the whole module, but the grid of steps and the gate types I could do I think. I'll take a look :-)

Eurikon commented 3 years ago

Yeah sorry I didn't mean the whole module, locking the steps is great enough!

Thanks, Marc! :)

MarcBoule commented 3 years ago

It's been added to the source and will be part of the next update which should be very soon, but if you build plugins, feel free to pull Impromptu! Cheers, Marc