search

MarcBoule / ImpromptuModular

Virtual Eurorack Modules for VCV Rack
Other
95 stars 10 forks source link

Static analysis issues #68

Closed cschol closed 1 year ago

cschol commented 1 year ago

Marc, as part of the integration process we now run CodeQL and cppcheck.

CodeQL issue found:

"Multiplication result converted to larger type","A multiplication result that is converted to a larger type can be a sign that the result can overflow the type converted from.","warning","Multiplication result may overflow 'int' before it is converted to 'uint64_t'.","/src/FoundrySequencerKernel.cpp","587","2
4","587","53"

cppcheck issues found: cppcheck-results.log

Take a look (specifically the cppcheck ones with out of bounds access) and see if any of these should be fixed. Thanks.

MarcBoule commented 1 year ago

Thanks for pointing those out, I hopefully have fixed them all. Cheers, Marc