HostInfo.IP.FilteredInterfaces() can include disconnected interfaces, causing exceptions in Connection.StartListening()

MarcFletcher / NetworkComms.Net

NetworkComms.Net is a high performance cross-platform network library written in C#.

http://networkcomms.net

Apache License 2.0

542 stars 242 forks source link

HostInfo.IP.FilteredInterfaces() can include disconnected interfaces, causing exceptions in Connection.StartListening() #26

Closed jasells closed 7 years ago

jasells commented 7 years ago

HostInfo.IP.FilteredInterfaces() ~ line 251 doesn't check the status of the interface, and so the example code will throw an exception if a NIC is in the system, but not connected to a cable, or disabled in Windows. This should avoid adding an inactive interface.

*Note I can't build the code to test, but will keep trying to figure out the issue. I am getting android build errors, even though I am not building android...?

MarcFletcher commented 7 years ago

Many kind thanks for the PR. I think this is the first in some time ;)

I'd be more than happy to take a look and merge this in but I'd kindly request that you ensure on the relevant diffs are included. At the moment there are a large number of files that I assume don't need to be updated.

MarcFletcher commented 7 years ago

It's been a couple of weeks. If I don't hear anything back I'll shortly close this PR.