search

MarcGiffing / bucket4j-spring-boot-starter

Spring Boot Starter for Bucket4j
Apache License 2.0
304 stars 66 forks source link

HazelcastSpringBucket4jCacheConfiguration support for SyncCacheResolver #292

Closed bryanxtong closed 5 months ago

bryanxtong commented 6 months ago

I have some problems as below

  1. When using cache-to-use “ hazelcast-spring”, HazelcastSpringBucket4jCacheConfiguration should be updated to support SyncCacheResolver and should not be AsyncCacheResolver which will not work ` @Bean @ConditionalOnMissingBean(SyncCacheResolver.class) public SyncCacheResolver hazelcastCacheResolver() {

    just for example as below

       return new HazelcastSyncCacheResolver(hazelcastInstance, false);

    } `

  2. Make changes for Bucket4jCacheConfiguration to include IgniteBucket4jCacheConfiguration for support ignite async and change IgniteCacheResolver#isAsync() return true

  3. Making Changes of the annotation @ConditionalOnCache("jcache-ignite") to @ConditionalOnCache("jcache-infinispan") for InfinispanJCacheBucket4jConfiguration is more clear

MarcGiffing commented 5 months ago

Can you please review #304