MarcGiffing / wicket-spring-boot

Spring Boot starter for Apache Wicket
151 stars 61 forks source link

Unable to change configuration-type when using devtools #170

Closed abiuan closed 4 years ago

abiuan commented 4 years ago

Hello, I saw that wicket starter forces configuration-type to DEVELOPMENT when devtools starter is activated, and I'm unable to change it. The change of configuration-type to DEPLOYMENT could be useful when testing CSS, for example, when wicket tags can be disturbing.

Regards

MarcGiffing commented 4 years ago

Is it OK to disable the property setting with wicket.spring.devtools.restart.enabled = false

abiuan commented 4 years ago

Hello,

"wicket.spring.devtools.restart.enabled" is not a recognized property.

Did you mean "spring.devtools.restart.enabled"? Using this property automatic restart of the embedded tomcat is disabled (that is what I do not want) but wicket tags are still present even if "wicket.core.settings.general.configuration-type" is set to DEPLOYMENT.

Regards

Alberto

P.S. I'm using wicket-spring-boot version 3.0.3-RC.

On Wed, 2020-07-01 at 11:14 -0700, MarcGiffing wrote:

Is it OK to disable the property setting with wicket.spring.devtools.restart.enabled = false

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

MarcGiffing commented 4 years ago

Its not yet released. I've commited it in the Wicket 8 branch. See my commit in this ticket.