search

MarcLavielle / mlxR

mlxR
Other
19 stars 5 forks source link

Matching of correlation parameters in simpopmlx #10

Open niklashartung opened 8 years ago

niklashartung commented 8 years ago

Hi,

in simpopmlx() line 31, correlation parameters are matched by grep("r_", pname)

Shouldn't it be grep("^r_", pname) (idem for corr_)?

Otherwise, any structural parameter ending in r will also be matched. This does not cause any problems as long as the parameter itself contains no _.

However, for a structural parameter named, say, k_gr, the following error appears: Maximum number of iterations reached: could not draw definite positive correlation matrix because it is mistakenly interpreted as a correlation parameter.

MarcLavielle commented 8 years ago

absolutely! bug fixed very soon on GItHub (mlxR 3.02) thanks...

Marc

2016-05-23 10:11 GMT+02:00 niklashartung notifications@github.com:

Hi,

in simpopmlx() line 31, correlation parameters are matched by grep("r_", pname)

Shouldn't it be grep("^r", pname) (idem for corr)?

Otherwise, any structural parameter ending in r will also be matched. This does not cause any problems as long as the parameter itself contains no _.

However, for a structural parameter named, say, k_gr, the following error appears: Maximum number of iterations reached: could not draw definite positive correlation matrix because it is mistakenly interpreted as a correlation parameter.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/MarcLavielle/mlxR/issues/10

http://www.cmap.polytechnique.fr/~lavielle/book.html

Marc Lavielle

CMAP, Ecole Polytechnique91128 Palaiseau Cedex

France Tel: (33) 1 69 33 46 47 (33) 6 37 31 93 05

Marc.Lavielle@inria.fr http://www.cmap.polytechnique.fr/~lavielle

"""""""""""""""""""""""""""""""""""""""""""""""""""""""""