MarcLavielle / mlxR

mlxR
Other
19 stars 5 forks source link

Shiny example "Modelling the ADME process with a PK model " not working with the last version of mlxR #14

Open Vincent-AC opened 7 years ago

Vincent-AC commented 7 years ago

Hello,

I executed the shiny example "Modelling the ADME process with a PK model", available at this URL : http://shiny.webpopix.org/dashboard/pkmodel/ . On the website it works fine, but I then downloaded the server.R and ui.R to try it locally with the idea to customize it later.

At first when i run it as is, i get an error that it doesn't find ReadMe.rmd, i strated by removing any mention of it. Then when I start the application i get the following error :

Warning: Error in simulxunit: MLXTRAN met a syntax error. Parsing ... Incomplete match for: , lexer and parser reached line 6.

After some debugging, I found where it came from, I think that the shiny application on your server is based on an old version of mlxR that accepted a list() as input for the argument "parameter" of the pkmodel() function. Nowadays the input of the "parameter" argument has to be a named vector instead of a list. I thus did minimal modifications to get the app working :

I hope that it will be useful to others !

MarcLavielle commented 7 years ago

Done

thank you!

Marc

2017-09-19 10:02 GMT+02:00 Vincent ARANZANA-CLIMENT < notifications@github.com>:

Hello,

I executed the shiny example "Modelling the ADME process with a PK model", available at this URL : http://shiny.webpopix.org/dashboard/pkmodel/ . On the website it works fine, but I then downloaded the server.R and ui.R to try it locally with the idea to customize it later.

At first when i run it as is, i get an error that it doesn't find ReadMe.rmd, i strated by removing any mention of it. Then when I start the application i get the following error :

Warning: Error in simulxunit: MLXTRAN met a syntax error. Parsing ... Incomplete match for: , lexer and parser reached line 6.

After some debugging, I found where it came from, I think that the shiny application on your server is based on an old version of mlxR that accepted a list() as input for the argument "parameter" of the pkmodel() function. Nowadays the input of the "parameter" argument has to be a named vector instead of a list. I thus did minimal modifications to get the app working :

  • line 80 : added a vector version of the parameter list with function setNames() p=list(name=param.name,value=param.value) #doesn't work because pkmodel wants a vector instead of a list p_vector <- setNames(param.value, param.name http://param.name)
  • line 99 : changed the parameter argument to use the newly created vector as input : res <- pkmodel(time=t.value,treatment=adm,parameter=p_vector)

I hope that it will be useful to others !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MarcLavielle/mlxR/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ3yuljB48QE5xQtxf89udfgHm3at5Ytks5sj3UdgaJpZM4PcAFC .

--

Marc Lavielle

CMAP, Ecole Polytechnique91128 Palaiseau Cedex

France Tel: (33) 1 69 33 46 00 (33) 6 37 31 93 05

Marc.Lavielle@inria.fr http://www.cmap.polytechnique.fr/~lavielle

"""""""""""""""""""""""""""""""""""""""""""""""""""""""""