search

MarcWeber / hasktags

Produces ctags "tags" and etags "TAGS" files for Haskell programs
Other
127 stars 32 forks source link

hasktags-0.70.1 test suite failure #52

Closed peti closed 5 years ago

peti commented 6 years ago 
Building test suite 'testsuite' for hasktags-0.70.1..
[1 of 4] Compiling DebugShow        ( src/DebugShow.hs, dist/build/testsuite/testsuite-tmp/DebugShow.o )
[2 of 4] Compiling Tags             ( src/Tags.hs, dist/build/testsuite/testsuite-tmp/Tags.o )
[3 of 4] Compiling Hasktags         ( src/Hasktags.hs, dist/build/testsuite/testsuite-tmp/Hasktags.o )
[4 of 4] Compiling Main             ( tests/Test.hs, dist/build/testsuite/testsuite-tmp/Main.o )
Linking dist/build/testsuite/testsuite ...
running tests
Running 1 test suites...
Test suite testsuite: RUNNING...
### Failure in: 3:16.hs:0:these were not found
tests/Test.hs:39
expected: ["t2","t3","t4","t5"]
 but got: []
Cases: 156  Tried: 156  Errors: 0  Failures: 1
Test suite testsuite: FAIL
jhenahan commented 6 years ago

That is currently a known failure. It's down to some weird record parsing issues that I’m trying to diagnose. I’m not sure what the normal way to handle this for releases is. I could remove the testsuite from releases, but I think I'd prefer for downstream tools to just avoid running the testsuite for simple installs. I'll see if this is something I can express in Cabal or something.

peti commented 6 years ago

How about disabling that one particular test that fails? IMHO, test suites should be run as much as possible to increase the likelihood of discovering issues in the code. It doesn't feel right to disable the entire test suite because of one failing test.

Anyhow, the best possible solution is always to fix the test suite. :-)

vvv commented 5 years ago

There are two failures now:

$ stack test
[...]
hasktags-0.70.1: test (suite: testsuite)

### Failure in: 1:16.hs:0:these were not found
tests/Test.hs:39
expected: ["t2","t3","t4","t5"]
 but got: []
### Failure in: 18:testcase12.hs:0:these were not found
tests/Test.hs:39
expected: ["Bar","Baz"]
 but got: []
Cases: 168  Tried: 168  Errors: 0  Failures: 2

hasktags-0.70.1: Test suite testsuite failed
Test suite failure for package hasktags-0.70.1
    testsuite:  exited with: ExitFailure 1
Logs printed to console
jhenahan commented 5 years ago

Fixed in version 0.71.