MarcWeber / hasktags

Produces ctags "tags" and etags "TAGS" files for Haskell programs
Other
127 stars 32 forks source link

force UTF8 for output files #77

Closed tek closed 2 years ago

tek commented 4 years ago

I was running hasktags in a nix derivation, where the locale is POSIX. Since GHC doesn't really allow source files to be anything other than UTF8, I think it would be reasonable to unconditionally set the output file encoding, though you might have a different view.

jhenahan commented 2 years ago

That does seem reasonable. I'm working on getting another PR merged in here, and I expect I can get this one in for the next release, as well. :)

jhenahan commented 2 years ago

I'll be merging this, but for the sake of safety I'm going to say this is a major release since mucking with character encoding is just asking to break a CI pipeline somewhere. :D Thanks for the PR!