search

MarcWeber / vim-addon-manager

manage and install vim plugins (including their dependencies) in a sane way. If you have any trouble contact me. Usually I reply within 24 hours
Other
660 stars 59 forks source link

echohl ... #48

Closed MarcWeber closed 13 years ago

MarcWeber commented 13 years ago 
echohl ErrorMsg
echom "Failed updating plugins: ".string(failed)."."
echohl None

This violates the "do it once' principle. There is too much copy paste. Eventually this should be call vam#Notice("...") or such. Yes, calling functions is slower - but speed doesn't matter in the error case anyway. Is there a reason to keep it as is? If not I"ll refactor that.

ZyX-I commented 13 years ago

No, there is not. It is not actually a copy-paste: not enough code to do this instead of retyping.

MarcWeber commented 13 years ago

12 times is enough to refactor IMHO. We agree to disagree :) ? Also note that refactoring allows us to document its behavior. I hope that the \n handling is fine.