search

MarcWeber / vim-addon-manager

manage and install vim plugins (including their dependencies) in a sane way. If you have any trouble contact me. Usually I reply within 24 hours
Other
660 stars 59 forks source link

Allow other protocols for git #62

Closed gotgenes closed 12 years ago

gotgenes commented 12 years ago

My workplace blocks the Git protocol port 9418. Unfortunately, VAM has hardcoded URLs for addons with a "git://" prefix, which causes Git to attempt to fetch repositories with the Git protocol. Can this please be replaced by a configurable protocol string set by the user, such as

let g:vam_git_protocol = "https"

so that, for those of us working behind draconian firewalls, VAM can still fetch plugins via Git?

MarcWeber commented 12 years ago

docs -> "Another example:"

Try with https instead

Which keywords did you use when searching for this? Looks like its hard to find. Should we use https by default?

gotgenes commented 12 years ago

[sigh] Nevermind; you have already documented this in the documentation. My sincere apologies.

gotgenes commented 12 years ago

Haha, sorry, I discovered the documentation right before you answered.

Which keywords did you use when searching for this?

I didn't. I actually greped for git:// in the source and saw that it was in the help documentation file, so then I ran :h vim-addon-manager.txt and spotted it. Not the smartest thing, I know. :-(

I would say it would be great to have that issue the FAQ in the docs (not yet present) under something like "VAM fails to clone git repositories because I am behind a proxy/firewall. What can I do?"

Should we use https by default?

git clone is faster over git:// and I think most people aren't behind tough firewalls, so I would vote that git:// is actually the right default protocol.

Thanks for the fast reply, by the way.

ZyX-I commented 12 years ago

I have chosen to make git:// default everywhere where it is allowed because it provides another feature: while you should do git+https:// to pull git https repository in mercurial (at least some time ago it worked only in dev version of hg-git with dev version of dulwich), git:// works fine.