search

Marcel-Rodekamp / NSL

Nanosystem Simulation Library (NSL) implements statistical simulations for systems on the nanoscale
Other
2 stars 0 forks source link

Pseudo fermions #114

Closed Chrisgant closed 1 year ago

Chrisgant commented 2 years ago

Action class improved and updated for new configurations.

Marcel-Rodekamp commented 2 years ago

We have to add a few things before we can merge

  1. Put in a proper implementation of the HubbardGaugeAction, not only returning some configuration
  2. Put in a proper implementation of the HubbardFermiAction, not only returning some configuration
  3. The template parameter should use the NSL::Concept concepts to increase compiler output readability and prevent bugs
  4. complex<double> needs to be templated when we return in e.g. float precision this might cause unexpected behavior (e.g. Action/action.tpp lines 35,52,85, ...)
  5. The files hubbardFermiActionsIsle.* should not be committed

Store the params struct explicitly in the private section.

Marcel-Rodekamp commented 1 year ago

This PR is out of Date, a newer version will come soon.