Some comparisons are backwards? - Githubissues

Marcel-Rodekamp / NSL

Nanosystem Simulation Library (NSL) implements statistical simulations for systems on the nanoscale

Other

2 stars 0 forks source link

Some comparisons are backwards? #133

Open evanberkowitz opened 1 year ago

evanberkowitz commented 1 year ago

I think some of our tensor comparison overloading functions are backwards.

In particular, I think these REVERSE the meaning of the inequality!

https://github.com/Marcel-Rodekamp/NSL/blob/1aada0df18ed87e64debb3ced80bed85867f0963/src/NSL/Tensor/Impl/operatorGreater.tpp#L18-L22

https://github.com/Marcel-Rodekamp/NSL/blob/1aada0df18ed87e64debb3ced80bed85867f0963/src/NSL/Tensor/Impl/operatorGreaterEqual.tpp#L18-L22

https://github.com/Marcel-Rodekamp/NSL/blob/1aada0df18ed87e64debb3ced80bed85867f0963/src/NSL/Tensor/Impl/operatorSmaller.tpp#L18-L22

https://github.com/Marcel-Rodekamp/NSL/blob/1aada0df18ed87e64debb3ced80bed85867f0963/src/NSL/Tensor/Impl/operatorSmallerEqual.tpp#L18-L22