search

Marcel-Rodekamp / NSL

Nanosystem Simulation Library (NSL) implements statistical simulations for systems on the nanoscale
Other
2 stars 0 forks source link

Trap with NSL::conj #78

Closed Marcel-Rodekamp closed 2 years ago

Marcel-Rodekamp commented 2 years ago

We have two overloads of conj in different namespaces:

template<typename T>
NSL::conj(T)

template<NSL::Concept::Number T>
NSL::LinAlg::conj(NSL::Tensor<T>)

which potentially causes issues if the LinAlg scope is forgotten. Two things to fix here:

  1. Merge the first version into LinAlg for propper overloading
  2. Add Concept::Number to the function
evanberkowitz commented 2 years ago

This was resolved before #104.