fetcher is called on every flutter build()

[Nico04]

Since 4.2.5, the fecther is called on every flutter build(), which is not desired. It should only be called on initState, pull-to-refresh or if controller.fetch() is manually called.

Maybe it's because of the fix of #4.

To reproduce using your example, you can add an action button to the CachedBuildDemo's scaffold's appbar :

actions: <Widget>[
          IconButton(
            icon: Icon(Icons.add),
            onPressed: () => Navigator.of(context).push(MaterialPageRoute(
              builder: (_) => Scaffold(
                body: Text('nothing'),
              ),
            )),
          )
        ],

When you tap on it, it will open a new page, flutter will call CachedBuildDemo's build(), and fetcher will be called (not desired).

[MarcelGarus]

Ooo, you're right. We should probably only call it the first time. I'll have a look at it later today.

Actually, the current behavior is somewhat intended as a temporary behavior. In the long term, I was thinking about implementing multiple caching strategies that you can choose from (for example, only fetching the first time or fetching only if the last fetch is some amount in the past)

[Nico04]

Implementing multiple caching strategies as you said is a great idea, but still, in anycase it should NOT be called on rebuild.

As Flutter's documentation say :

A general guideline is to assume that every build method could get called every frame.

So maybe before you add this multiple caching strategies implementation, you could just fix this ? Thanks :)

[MarcelGarus]

Yes, I'll fix it later today 😊

[MarcelGarus]

Got fixed with version 4.2.6, which is already live on pub.dev.

[Nico04]

It fixes the build issue, but now I can't pull-to-refresh anymore, is that normal ?

[MarcelGarus]

I tested pull-to-refresh on my device and it worked…

[Nico04]

You're right : it's another issue.