search

Marcelh1983 / angular-document-viewer

MIT License
62 stars 23 forks source link

Validations for multiple iframes for reloading google document #55

Closed itsLucario closed 4 years ago

itsLucario commented 4 years ago

Doc viewer won't work if there are multiple iframes. Cause reloading works based on iframe.src = iframe.src and it replaces src of some other iframe.

So added validations to check whether it's updating src of document viewer iframe.

Marcelh1983 commented 4 years ago

Thanks for the pull request. I just tried to solve your issue using a QueryList to retrieve the iframe I didn't like the way I retrieved the iframe anyway. Could you check if 1.2.2 works for you?

itsLucario commented 4 years ago

Actually I tried this approach. But for some reason it is not working with the module, I tried to debug but didn't get to know why its not working. That is the reason I went with alternate approach.

Can you cross check by debugging whether QueryList is returning iframes or not? I tried with 1.2.2 it's not working

itsLucario commented 4 years ago

I have fixes the issue with ViewChildren. Let me know if its good.

Marcelh1983 commented 4 years ago

Thanks a lot @itsLucario I make a stupid mistake, thanks for fixing. 1.2.3 should work.

itsLucario commented 4 years ago

Thanks a lot @itsLucario I make a stupid mistake, thanks for fixing. 1.2.3 should work.

😄