Open RedJocker opened 2 years ago
Hi Marcell I have reviewed your comments on reports and added some comments as well.
It looks like the third tester that was assigned has bailed, so we will take a new tester to finish the testing phase.
But we can already work on the issues found by the other two reports. So first I think you should get the current version from stepik since there where changes already and update here to match that. Don't forget to keep a branch with the current state, it may be useful if you decide to revert some of the changes later on. Then open issues on the issues you intent to fix based on reports and the comments we added.
Besides test reports there is already comments on project stages and posted solutions, since the project is already published on beta, you may be interested on seeing those too.
What do you mean by "Can you already download the project from stepik? have you received the document that explain that? I think you should download the current version and commit it here."? I can update the project in Android Studio if there are any changes in the GitHub repository
The code is uploaded to stepik when it goes to production. The current version is there and when you finish fixing we are supposed to upload it there the new version.
I was asking if you have permission to download the project from stepik so that you can have the current version
I don't know about that. I only have access to the stage descriptions on stepik (what I've written at the beginning of the project)
ok, I will see about that, in the worst case I will send a pull request with the current version
I have uploaded the current version here https://github.com/RedJocker/secret-diary-review/tree/stepik
I think it is better to have a new branch for that, but I can't pull request directly into a new branch, you have to create a new branch first then I can do a pull-request into that new branch. Make a new branch from the main branch named stepik I will pull-request the current version to your repository.
The guy that uploaded the code also renamed one of the base folders from "secret-diary" to "Secret Diary" so git is thinking secret-diary was deleted and Secret Diary was created, which unfortunately makes harder to follow the changes. You should work making your changes over this version
Okay, now I have a 'stepik' branch: https://github.com/Marcell-Juhasz/secret-diary/tree/stepik
the last tester has finished the report https://docs.google.com/document/d/1mWkdecL3seZDz2HM6Ss2gYEDXG1b-jW6XxYDR4JJyvc/edit
I think there is only one comment that may be relevant for us on stage4, but some investigation is needed to see if it is pertinent or not.
I see, I will take a closer look in the following days at how could we solve that
Well, I was unable to reproduce the error. I can not even imagine that if the user tests their code on their real or virtual device, how could it affect the robolectric tests. SharedPreferencis connected to the installed application, robolectric is totally independent of the installations. What do you think?
you are talking about the SharedPreferences comment on stage4 right?
open a new issue with title "maybe issue with SharedPreferences" or something like that and then paste the reviewers comment.
Since you don't have permissions to look at users submissions I will take a look on that for you and possible pass you some user code to test.
It is also possible to make questions for tester on google docs to have some clarification on what is the issue
do you think it is all done or are you still working in something? if it is all done I will update the project.
ps: jitpack repository seem to be down, so if you try to open the project it will probably give you build failure. In that case add this repository to settings.gradle and project build.gradle
maven { url 'https://packages.jetbrains.team/maven/p/academy/hyperskill-hspc' }
I've added the new repo. I guess it's all done, you can update
Hey marcell, how is it going?
Alexandra has told me you had some questions about test reports and fixing the project.
first thing I think you should do is comment the reports, the problem is that reporters have not shared it with permission to comment as they should have, but I have asked Ale to fix that so you should soon be able to comment on the report. The main comments intention is to make marks on points of interest for fixing, it helps keeping track of things. You can also make marks of things related to topics team to give warnings for the topics team on where to look. For an example look at this other project report https://docs.google.com/document/d/1qEh480dFMWYLQI7PWYAlFRaEnNMv0BwvnUBw06usLWU/edit#heading=h.nati7fj400rp
second thing, for a while there was a mixup and my manager though I was assigned to do the fixing and there was one issue that really had to be fixed during tests so that testers could complete the test. It was an issue with the AlertDialog, there are two versions possible to import, but only one works, I did some changes on the internal that were to improve error messages, but them the upload had problems and I had to fix the fix. Also some other fixes were made, mostly to description.
Can you already download the project from stepik? have you received the document that explain that? I think you should download the current version and commit it here. Also duplicating this branch to save this pre-test version is probably a good thing to do.
I really recommend you opening issues on the things you want to work on, that is a good driver for this kind of work. I have marked this project to watch so I think I'll be notified already, but tag me to make sure I see it.
Also another question, can you see submissions? because that helps me a lot to fix projects. We can really see what kind of failures, if error messages are enough to figure that out or if there is need to look much closer, how are tester testing (most go on a as fast as they can complete the project, which I think is the wrong frame of mind for a tester job, they should be trying to find the most bugs as they can, that is what I used to do), where they are struggling and if the struggle is their fault (most probably isn't keep that on mind, description should be clear enough as to avoid confusion and/or misinterpretations). This job is much like an investigative job, you have to take a look for the cues and interpret things, figure out error messages and user struggles.