search

MarceloPrado / has-changed-path

GitHub Action that saves time and money in monorepo environments
MIT License
225 stars 33 forks source link

Use JavaScript to avoid build #5

Closed ad-m closed 4 years ago

ad-m commented 4 years ago

Hello,

I suggest convert you action to use JavaScript action nor Docker. It allows skips build process and speed up execution of actions a lot. GitHub Actions environment provide already git, so you don't need Docker at all.

See also https://github.com/ad-m/github-push-action/issues/26 .

Greetings

MarceloPrado commented 4 years ago

Hey @ad-m !

Thanks for the insight, I didn't know it was faster. I'll take a look at it this week to measure how much faster this could get.

Cheers

ad-m commented 4 years ago

@MarceloPrado , you can at all eliminate build time, so it's 13 seconds faster out of 14 seconds (13 second build + 1 second run).

MarceloPrado commented 4 years ago

Nice, good to know! I'll work on the conversion as soon as possible and let you know once it's done.

eniltonj commented 4 years ago

I'd like to use this on Windows, so converting to Javascript would be great.

MarceloPrado commented 4 years ago

@eniltonj and @ad-m , sorry for the delay. Here's the PR that converts to JS.

If you could test it, I would appreciate it!

Thanks, Marcelo