search

MarchosiasM / irlgamers

MIT License
0 stars 3 forks source link

User Authentication needs work #12

Closed dimstar closed 6 years ago

dimstar commented 6 years ago

After doing a bunch of digging I think user auth should be done one of two ways:

  1. with an async middleware for react components so that we don't end up with where we are now.
  2. we should leverage local storage token for authentication so that we don't have t async call firebase. we could even beef this up with some user model validation/security.

areas effected...

client/modules/App.js client/modules/Auth/AuthActions.js

and functions related...

onAuthStateChanged() fetchAuthUserRequest()

MarchosiasM commented 6 years ago

@rperez2021 is currently working on this.

Roberto are you tracking these issues?

Also, what's the end vision on the login window?

On project 1 you had a nice little login option in the upper left that then opened up into a bigger "select which domain you'd like to login from," is that where this is going to end up?

rperez2021 commented 6 years ago

Closing this, this has been resolved.