search

MarcinMoskala / KtAcademyPortal

Multiplatform Kotlin application of KotlinAcademy
Apache License 2.0
444 stars 55 forks source link

Use kotlin+buildSrc to manage dependencies #37

Closed jmfayard closed 6 years ago

jmfayard commented 6 years ago

more kotlin, better IDE integration

image

MarcinMoskala commented 6 years ago

I see value in strings extraction, but in the same time I see problem in having mixed Groovy-Kotlin Gradle configuration. It would make sense if all Gradle configurations would be moved to Kotlin

jmfayard commented 6 years ago

It would make sense if all Gradle configurations would be moved to Kotlin

yes, that would be an interesting experiment I don't have time right now to do that, but I would like to try someday

I see value in strings extraction, but in the same time I see problem in having mixed Groovy-Kotlin Gradle configuration.

I would ask: problem for who? Not for gradle, it offers a java api and does not care wether you configure it with java or groovy or kotlin or a mix. Not for the developer. If she is interested by this project, we can assume she knows kotlin. The buildSrc+kotlin solution is super focused on a well known pain point around managing dependencies, the IDE integration makes it a superior alternative. Nothing else changes.

Edit: one possible drawback may be for people who have an older version of intellij or android studio, without the work done on integrating the kotlin dsl.

jmfayard commented 6 years ago

@MarcinMoskala Are you still interested in having all gradle configuration files migrated to Kotlin? I would like to give it a try to see how that goes.

jmfayard commented 6 years ago

I will submit a better pull request