MarcinOrlowski / crypto-tracker-plasmoid

Plasma/KDE multi crypto currency price tracker widget, with support for multiple exchanges and currency pairs.
24 stars 8 forks source link

Fiat currency not selectable #7

Closed othbert closed 3 years ago

othbert commented 3 years ago

What's wrong? Currency appears to default to the first in the list for a given exchange, the selection opens when clicked but not possible to choose from the options.

Steps to reproduce the behavior:

  1. Add a crypto to track
  2. Choose an exchange
  3. Attempt to change fiat currency representation

Expected behavior The clicked currency should be selected.

Runtime environment

Notes Any additional information that may be helpful diagnosing the problem.

Thanks for making this tracker! Additionally, the crypto value does not update when applying changes, it waits until the next refresh. Not really a bug, but would be cool to see changes reflected immediately via a call to refresh the plasmoid.

MarcinOrlowski commented 3 years ago

I cannot confirm this. Please be more precise - what exchange and what crypto? Also note each exchange can have different pairs for each crypto.

othbert commented 3 years ago

Oh that's interesting, happened for me with all and every exchange and crypto. Could not select any fiat except the one that happened to be first in the list, whether that was PZ, CZ or USD. For example, ETH on Kraken, defaults to USD for me and unchangeable.

MarcinOrlowski commented 3 years ago

There's logic that watches exchange/crypto/fiat changes to ensure your config is always valid for given combination and if not (i.e. you switched from Bitbay to Kraken which does not support PLN, it would fall back to first supported fiat for specified crypto on Kraken) so there's a chance there's something there that makes it malfunction in some cases, but for now I am unable to reproduce this locally. Have used 1.0.0 and then upgraded to 1.1.0 or it's your fresh installation?

othbert commented 3 years ago

This is on a brand new install via plasma panel's add widgets -> get new widgets dialog. Yeah, the list of supported fiat changed correctly per exchange and crypto, and the dropdown opens, just that after clicking one, e.g. EUR for ETH @ Kraken, the dropdown would close and USD would still be selected. I don't know if this is any help, but the dropdowns do not behave quite like other plasma settings dialogs. There is no indication by highlighting which row in the dropdown is selected as you hover over them, and keyboard navigation in the rows does not appear to work for me.

MarcinOrlowski commented 3 years ago

Good news. I managed to reproduce the issue.

othbert commented 3 years ago

Thanks, works perfectly now!

MarcinOrlowski commented 3 years ago

Great. Thanks for reporting the issue.