search

MarcinOrlowski / laravel-api-response-builder

Builds nice, normalized and easy to consume REST JSON responses for Laravel powered APIs.
MIT License
720 stars 79 forks source link

Improve CI #234

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

Please hold on tight. Thank you.

kép

diffs without whitespace changes: https://github.com/MarcinOrlowski/laravel-api-response-builder/pull/234/files?diff=unified&w=1

szepeviktor commented 1 year ago

Benefits

CS in source code can be fixed this way.

    protected function buildResponse(
        bool $success,
        int $api_code,
        $msg_or_api_code,
        array $placeholders = null,
        $data = null,
        array $debug_data = null
    ): array {
MarcinOrlowski commented 1 year ago

Thanks for the PR. I will not merge it however - there's re too many changes in the code to merge this one. Also I am not convinced to some of the changes you made but I will try to cherry pick something once I got 9.4.0 out.

szepeviktor commented 1 year ago

All right. My processes are usually too much as I'm thinking about bugs all day long. Here you find my daily committed knowledge. https://github.com/szepeviktor/debian-server-tools/blob/master/webserver/Continuous-integration-Continuous-delivery.yml There are similarly named CI workflow files beside it.