search

Marcnuth / AnomalyDetection

Twitter's Anomaly Detection in Pure Python
Apache License 2.0
304 stars 76 forks source link

modularize code #21

Closed hokiegeek2 closed 5 years ago

hokiegeek2 commented 5 years ago

Hi Everyone, This algorithm works really well and we'll be using it in production. To that end, I wanted to modularize the code and add corresponding unit tests to make it easier to enhance this excellent implementation of the Twitter algorithm.

@Marcnuth Pull request coming soon

--John

JonnoFTW commented 5 years ago

Do you plan on improving the anomaly_detect_vec function? Your fork doesn't seem to work when reindexing is required because of too small a granularity.

hokiegeek2 commented 5 years ago

Hi @JonnoFTW I can take a look, please provide more information including the parameters and the test file(s) you tried.

JonnoFTW commented 5 years ago

@hokiegeek2 my data is private, so I'll have to send it to you privately. The code is here: https://github.com/JonnoFTW/incident_detection_eval/blob/master/sesd.py

Is your email your github user name @gmail.com? If so I'll send you the data there.

hokiegeek2 commented 5 years ago

Yes, hokiegeek2@gmail.com

Sent from my iPhone

On Dec 10, 2018, at 6:38 PM, Jonathan Mackenzie notifications@github.com wrote:

@hokiegeek2 my data is private, so I'll have to send it to you privately. The code is here: https://github.com/JonnoFTW/incident_detection_eval/blob/master/sesd.py

Is your email your github user name @gmail.com? If so I'll send you the data there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.