search

MarcoAttene / VolumeMesher

Convex Polyhedral Meshing for Robust Solid Modeling
52 stars 11 forks source link

Attribution of Delaunay code #3

Closed marotc closed 2 years ago

marotc commented 2 years ago

Hello Marco,

First, I must say that I appreciate your work and I am pleased that you cited my paper in both those 2 excellent papers.

Looking at this repository and also in VolumeRemesher, I could not help but notice that you did not only take inspiration from my sequential Delaunay code for the data structure used in your Delaunay code, but you also clearly copied and modified some part of the source. You are in your right to do so, and it is even an honor for me, except you must carry a notice stating that you modified hxt_seqdel in some way.

I would be glad if you could just include a little statement like this in both delaunay.h and delaunay.cpp:

/* This file contains modified source code from hxt_SeqDel (Copyright (C) 2018 Célestin Marot), a sequential Delaunay triangulator hosted at https://git.immc.ucl.ac.be/hextreme/hxt_seqdel as of 2020 (commit d5a9a762f6378edaf2e4dadf2acd6fe441b766e9) */
MarcoAttene commented 2 years ago

Hi Celestine, thanks for pointing this out. Statement included.