search

MarcoBuratti / Progetto-IngSw2018-Sagrada

2 stars 0 forks source link

Test & compilation issues #2

Closed valerio-castelli closed 6 years ago

valerio-castelli commented 6 years ago

Good afternoon, There is an issue with your pom.xml configuration that prevents Jenkins from successfully identifying and building your tests. Please follow the "junit 5 maven" guide that you can find on Google to fix the pom and make sure that you are able to run your tests within IntelliJ using a maven build configuration with "test" as goal.

valerio-castelli commented 6 years ago

UP: your pom.xml is still incorrect and we still can't see your tests. You must follow this guide thoroughly until the end and, in particular, be sure to also include in your pom.xml the following plugin:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-surefire-plugin</artifactId>
    <version>2.19.1</version>
    <dependencies>
        <dependency>
            <groupId>org.junit.platform</groupId>
            <artifactId>junit-platform-surefire-provider</artifactId>
            <version>1.1.0</version>
        </dependency>
        <dependency>
            <groupId>org.junit.jupiter</groupId>
            <artifactId>junit-jupiter-engine</artifactId>
            <version>5.1.0</version>
        </dependency>
    </dependencies>
</plugin>

Please fix this ASAP!

valerio-castelli commented 6 years ago

I can confirm this has now been fixed. However, please be aware that one of your tests is currently failing: Tests in error: ShadesTest.scoreEffect:29 » NullPointer

valerio-castelli commented 6 years ago

You still have a few tests failing: Tests in error: TurnTest.turnManager:92 » IllegalMonitorState DashboardTest.jsonTester:177 NullPointer ShadesTest.scoreEffect:29 » NullPointer

sergiocanzoneri commented 6 years ago

All the tests are running correctly on our machines. We also removed spaces from json files' names (we're currently using underscores instead of spaces). Could you please suggest a possible solution to the problem?

valerio-castelli commented 6 years ago

I think this was fixed and was due to a problem with case sensitive file system. However, your code is now not compiling due to the following issue: /var/jenkins_home/workspace/LM46/src/main/java/it/polimi/ingsw/client/View.java:[3,50] package com.sun.xml.internal.ws.policy.privateutil does not exist Please make sure you don't make use of any class belonging to the com.sun.xml.internal package.

valerio-castelli commented 6 years ago

Your code is still not compiling because of this issue. Please fix it asap!

sergiocanzoneri commented 6 years ago

We have fixed the problem with the test, but we cannot see the where we make use of a class belonging to this package. Also, we are quite sure we didn't make use of that package as it's the first time we see that package name. Could you please give us some advice in order to fix the problem?

ingconti commented 6 years ago

not working yet:

[INFO] /var/jenkins_home/workspace/LM46/src/main/java/it/polimi/ingsw/server/model/GameBoard.java: Recompile with -Xlint:unchecked for details. [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /var/jenkins_home/workspace/LM46/src/main/java/it/polimi/ingsw/client/View.java:[3,50] package com.sun.xml.internal.ws.policy.privateutil does not exist [INFO] 1 error

valerio-castelli commented 6 years ago

It's now working, I'm closing the issue.