MarcoDiaz2000 commented 1 year ago

Link to our project: GitHub project Our team is formed by 2 coding partners: @wilhelmk109 @MarcoDiaz2000

TedLivist commented 1 year ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @WilhelmK109 and @MarcoDiaz2000,

Good job so far! ✔️ Kanban columns are complete ✔️ Tasks are well-assigned However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

[x] Kindly add the issue for the unit and integration tests task.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

MarcoDiaz2000 commented 1 year ago

Thanks

Qoosim commented 1 year ago

Status: Approved :tada: :heavy_check_mark:

Hi @team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Implemented required changes. :heavy_check_mark:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.