Closed jeremiedbb closed 1 year ago
thanks for your PR!
I think what we also need is some example of how to set configuration in the readme
Unless there's an example of a package which uses cython-lint but can't use pyproject.toml, I'd suggest dropping setup.cfg, let's keep things simple
Unless there's an example of a package which uses cython-lint but can't use pyproject.toml, I'd suggest dropping setup.cfg, let's keep things simple
Okay, let's keep it simple for now. We can add support for setup.cfg if there's demand
🤔 not sure why half the jobs are cancelled without even starting
Do you know why the ubuntu jobs are cancelled ? I just see them cancelled but no detail is given
I don't know - want to try ubuntu-latest instead of ubuntu-18.04?
I was looking at https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/
It seems that the image is deprecated and should have been removed a while ago :)
awesome! just needs a little example in the readme, then we can merge
We can add support for setup.cfg if there's demand
sure - OK if I add you as collaborator?
Sure, no problem, thanks !
Fixes #64
This PR adds the possibility to set the configuration either from
pyproject.toml
or fromsetup.cfg
.I chose to support
setup.cfg
as well because I read a lot of discussion regarding the transition to pyproject.toml and it seems that it has not been adopted by a bunch of projects. The main reason I found was the issue that it automatically triggers isolated builds even when you want to install in editable mode. Sincecython-lint
is used exclusively by projects that do have some compilation, I thought it was more convenient to supportsetup.cfg
.