make CYTHON_VERSION check more precise

MarcoGorelli / cython-lint

Lint Cython files

MIT License

68 stars 11 forks source link

make CYTHON_VERSION check more precise #77

Closed derHolle79 closed 1 year ago

derHolle79 commented 1 year ago

Cython versions > 3.0a1 introduced change to AssertStatNode and renamed attribute "cond" to "condition". Made version check more precise to account for this subtlety.

MarcoGorelli commented 1 year ago

thanks for your PR, but this seems to be causing some test failures

derHolle79 commented 1 year ago

Turns out the switch between cond and condition was made in Cython rel 3.0a4. Also - their versioning scheme is a little inconsistent - starting with 3.0.0a8 it's a triplet. It should work now with the latest push.

MarcoGorelli commented 1 year ago

thanks for your PR

I feel quite nervous about comparing versions like this, happy to just consider this an upstream bug and leave it in. I don't see why anyone would still be using this alpha version anyway

closing then