search

MarcoGorelli / pydataglobal-21

2 stars 2 forks source link

Probability Distribution Function Plots require additional labelling in the X and the Y axis. #1

Open PhilipeRLeal opened 3 years ago

PhilipeRLeal commented 3 years ago

Dear @MarcoGorelli,

Since your presentation at PYDATA 2021 (this morning), I have been testing and studying your example using numpyro for MCMC models.

I noticed that the Probability Distribution Plots (within the Jupyter-notebook) could be better documented by means of adding labels to the matplotlib.Axes.axis "X" and "Y". At the present moment, solely the "Y" axis is labeled (e.g., with the word "Density").

Let's take the second figure of the Jupyter Notebook as an example (cell 15):

Since its "X" axis range from 0 up to 1, I am having trouble understanding its meaning. Therefore, my suggestion is to add some labelling to this axis.

Notice here that the same Issue is applicable to the figure at cell 20 of the provided Jupyter-Notebook.

Let me know your thoughts.

Sincerely,

MarcoGorelli commented 3 years ago

Hey @PhilipeRLeal

Thanks for your feedback! Do you want to submit a pull request?

PhilipeRLeal commented 3 years ago

I definitely would like to do it. Nevertheless, I am unsure of the plot labelling; what would be the xlabel of the axis? Could you aid me here? Once I properly understand what the xaxis represents, I can make a Pull Request for it.

PhilipeRLeal commented 3 years ago

After some brainstorming, I got wondering whether the "xaxis" of those plots represented the likelihood of each of the classes applied in the model (i.e., the High-School, Bachelor, Masters and Ph.Ds). If that supposition is correct, I presume that we could add a label to the xaxis of each of the subplots varying from ["Not-Likely to Know the Language" <-> "Likely to Know the Language"].

Let me know your thoughts.

Sincerely,

MarcoGorelli commented 3 years ago

Ah, it's the probability of having a given education level

PhilipeRLeal commented 3 years ago

Dear Marco,

I have updated the Repository with a set of explanations and a further in-depth discussion of the results.

Please, let me know if my Pull Request is OK, especially with respect to the results discussion and comments provided.

Sincerely,

Philipe Riskalla Leal Ph.D. in Remote Sensing (INPE - Brazil) MSc in Sciences (USP - Brazil)

Em sex., 29 de out. de 2021 às 19:34, Marco Edward Gorelli < @.***> escreveu:

Ah, it's the probability of having a given education level

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarcoGorelli/pydataglobal-21/issues/1#issuecomment-955084138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYJVORLRDKBY4JOX4UC6GDUJMVQHANCNFSM5HAGPNJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

MarcoGorelli commented 3 years ago

Thanks, much appreciated! I'll take a look when I get a chance