MarcoIeni / glimpse

✨ Mnemonic key bindings for VSCode commands
https://glimpse.ieni.dev
MIT License
22 stars 1 forks source link

Rolling motion - sequence not detected #293

Open arabshapt opened 8 months ago

arabshapt commented 8 months ago

Hi, great plugin:) in vspacecode I can do rolling motion e.g. leader ua very fast and it works every time, but not in glimpse. It stops at u.

MarcoIeni commented 8 months ago

Hi, thanks!

What's your which key config? In particular, do you have a delay?

arabshapt commented 8 months ago

It is pretty much stock. It seems like it has the same problem Ataman plugin in intellij has. If I understood it correctly, then each key is taken by each pop-up/command pallet, so while transitioning from one menu to the next one the keys are lost. Solution in both cases(Ataman and glimpse) could be to record key sequence separately and passing them to command pallet(your popups) or if they are final(complete sequence) then executing the command without pop-up(like whichkey)

arabshapt commented 8 months ago

No delay in vspacecode

arabshapt commented 8 months ago

I activate it vspacecode menu with custom shortcut

MarcoIeni commented 7 months ago

record key sequence separately and passing them to command pallet

Your analysis seems correct. If the proposed solution doesn't complicate the code too much, I'm happy to review a PR that implements it. 👍

Also, this issue seems related: https://github.com/VSpaceCode/vscode-which-key/issues/85