MarcoIeni / intellimacs

Spacemacs' like key bindings for IntelliJ platform.
MIT License
536 stars 94 forks source link

Assign which-key names to all key bindings #17

Closed MarcoIeni closed 3 years ago

MarcoIeni commented 3 years ago

We are working on the branch which-key in order to add which-key support to intellimacs. We have to assign to each key binding the name to be showed in idea-which-key.

You can see the current status of the work in PR #15. This PR is automatically updated once PR against the which-key branch are merged. In order to contribute, leave a comment to tell on which module you want to work and then open a PR against the which-key branch where you add the name of the key bindings. For an example, see #16. As you can see from the examples, modules can be both under spacemacs and extra.

updated modules:

If you want to try this follow the instructions of the readme of #15 and do:

cd ~/.intellimacs
git pull
git checkout which-key

P.s. you don't need to be an expert to contribute, you can also edit a file from your browser. Just make sure you are in the which-key branch.

jmrah commented 3 years ago

Hi @MarcoIeni. I'm interested in having a stab at buffers.vim You can go ahead and make a checkbox on that one.

Question about the naming of keybinding values that show up in the which-key menu. Consider these two keybindings in Spacemacs:

1) SPC -> b -> b -> list-buffers
2) SPC -> b -> d -> Kill buffer

Spacemacs often uses snake-case like in 1), but in other places uses the format of 2).
Do you have any opinion on which format the keybinding descriptions should take in intellimacs?

MarcoIeni commented 3 years ago

Thanks for helping! I am using snake-case everywhere. No reasons in particular.

jmrah commented 3 years ago

Understood. I will follow suit, and use snake-case in my PR.

jmrah commented 3 years ago

@MarcoIeni in your original post, you have the zoom.vim checkbox unchecked. I believe this menu was done in PR #28

MarcoIeni commented 3 years ago

Thanks everyone! I will try to release this in the next hours

MarcoIeni commented 3 years ago

Released it! Run git pull inside .intellimacs directory to update. If you experience some issues, open an issue and do git checkout 8e29374c17caff55c29c973ccf3c8555599a78ed to go back to the previous version.