MarcoIeni / intellimacs

Spacemacs' like key bindings for IntelliJ platform.
MIT License
536 stars 94 forks source link

Which key restart ide #45

Closed sweetliquid closed 3 years ago

sweetliquid commented 3 years ago

Description

Please explain the changes you made here.

Checklist

CHANGELOG:

KEYBINDINGS:

PLUGINS:

MarcoIeni commented 3 years ago

Great! What do you think about using this action as spc q r instead of spc q R and moving InvalidateCache to spc q R

i.e.

let g:WhichKeyDesc_Quit_InvalidateCache = "<leader>qR invalidate-cache"
nnoremap <leader>qR    :action InvalidateCaches<CR>
vnoremap <leader>qR    <Esc>:action InvalidateCaches<CR>
let g:WhichKeyDesc_Quit_Restart = "<leader>qr restart"
nnoremap <leader>qr    :action RestartIde<CR>
vnoremap <leader>qr    <Esc>:action RestartIde<CR>
sweetliquid commented 3 years ago

Please Take A Look

MarcoIeni commented 3 years ago

Awesome! can you update CHANGELOG and KEYBINDINGS, too?

In changelog I would say that now spc q r just restarts the IDE without invalidating the cache, too.

While in keybindings I would change spc q R to Invalidate cache.

What do you think? Tell me if you have some doubts. Thanks.

MarcoIeni commented 3 years ago

Also, can you rename the PR to something more meaningful? Because that will be the commit message.

sweetliquid commented 3 years ago

That's great, can you please review again?

MarcoIeni commented 3 years ago

Thank you so much!