MarcoIeni / release-plz

Publish Rust crates from CI with a Release PR.
https://release-plz.ieni.dev
Apache License 2.0
721 stars 66 forks source link

feat(backend): GitLab on-premise support and multilevel URLs, SSH git repos #1521

Closed mbodmer closed 2 weeks ago

mbodmer commented 3 weeks ago
mbodmer commented 3 weeks ago

Sorry, I have made a mess with git. Have now force pushed again and fixed the last clippy warning

mbodmer commented 2 weeks ago

Would you mind approving the builds? Or is there anything i can do?

MarcoIeni commented 2 weeks ago

Done! I'll review this asap

MarcoIeni commented 2 weeks ago

I extracted your fix in https://github.com/MarcoIeni/release-plz/pull/1528 because I wanted to merge it asap, thanks!

MarcoIeni commented 2 weeks ago

I tested this, and I got the error:

Error: failed to release package

Caused by:
    0: Failed to create release
    1: HTTP status client error (403 Forbidden) for url (https://gitlab.com/api/v4/projects/MarcoIeni%2Fmarco-test-gitlab/releases)
mbodmer commented 2 weeks ago

yes, the project Name is URL encoded, so 2%F is correct for the "/". Also you have to chose Maintainer role or any role with permission to create MR, for the token. The instructions still apply, just the role could be mentioned, i made the same mistake first. The error is also not very helpful, but I had no idea how to make it more meaningful. Thanks for reviewing and testing!

MarcoIeni commented 2 weeks ago

I'll test again, thanks! For the error, we could link to the docs if gitlab returns a 403. Do you mind doing this change and updating the docs? If not, I can do it 👍

mbodmer commented 2 weeks ago

You seem to have a solution in mind, just go for it