Peer-to-peer code review - Githubissues

MarcoOquendoC / toDoList

"To-do list" is a tool that helps to organize your day. It simply lists the things that you need to do and allows you to mark them as complete.

MIT License

7 stars 0 forks source link

Peer-to-peer code review #8

Open armandocomellas1 opened 2 years ago

armandocomellas1 commented 2 years ago

Great job so far but l have some recommendations fo you:

Use event listener mousedown and mouseup to trigger the function.
Also you will need to calculate the position between each container for that you can use this piece of code:

function getDragAfterElement(container, y) { const draggableElements = [...container.querySelectorAll('.draggable:not(.dragging)')]; return draggableElements.reduce((closest, child) => { const box = child.getBoundingClientRect(); const offset = y - box.top - box.height / 2;
```
if (offset < 0 && offset > closest.offset) {
  return {
    offSet: offset,
    element: child,
  };
}
return closest;
```
}, { offset: Number.NEGATIVE_INFINITY }).element;

Good luck and great work!