search

MarcosMeli / FileHelpers

The FileHelpers are a free and easy to use .NET library to read/write data from fixed length or delimited records in files, strings or streams
https://www.filehelpers.net
MIT License
1.13k stars 349 forks source link

Removed use of obsolete LCID code usage in culture converter. #413

Closed Joren-Thijs closed 3 years ago

Joren-Thijs commented 3 years ago

Solves #412

I have removed the use of CultureInfo.CurrentCulture.LCID in CultureConverter and replaced it with CultureInfo.CurrentCulture.Name as proposed by @tarekgh in this issue.

Since this is a small change i have gone ahead and submitted a quick PR.

Unfortunatly i cannot succesfully run the net Framework tests on my machine. Since it wrongly identifies the path to the test data files. The net core test however i can run succesfully and are passing for me. I am therefore going to create the pull request so i can use this projects CI tests.

I have also created another local commit expanding the targeted frameworks of the testing project to include both net 5 and net 6. let me know if you want this commit to be included. Also do you want any specific new unit tests to be included?

mcavigelli commented 3 years ago

Thank you for your pull request. I will look into it tomorrow.

Matthias

mcavigelli commented 3 years ago

Thank you for offering new unit tests.

In case you reproduce the erroneous behavior before the fix, those would be very welcome.

Matthias