search

MarcosNicolau / whatsapp-business-sdk

Node.js connector for the WhatsApp Business APIs with TypeScript support, integration tests and more.
MIT License
81 stars 21 forks source link

Fix: Current ruleset "Review needed" requires a pull request before merging #45

Open tecoad opened 1 month ago

tecoad commented 1 month ago

@MarcosNicolau Current GH action for release 'semantic-release' is trying to push changes (version updates and tags) directly to the main branch as can be seen here, which is nonetheless being blocked by the current repository rules.

We have three possible workarounds:

  1. Modify repository rules.
  2. Use a different branch for releases.
  3. Use semantic-release's GitHub Action This GitHub Action for semantic-release that might handle these permissions better (i never used it though, so we have to test it). Why this PR does.

Feel free to take the best approach in your opinion.

MarcosNicolau commented 1 month ago

I was about to address this problem. Your solution looks good, but I don't think it will work since it requires creating a personal access token with the necessary permissions, which adds the overhead of making sure we are not persisting credentials. For now, I'm gonna re-trigger the ci and disable the branch rules, which I just added to know if another contributor(you) has viewed and approved the changes(saving me some work haha). Let's leave the pr open though, I liked the comment and the workaround list :smile:

lukas-becker0 commented 1 month ago

Also can we squash the commits of PRs before merging ?