search

MarcusBarnes / islandora_compound_batch

Provides the basic ability to batch import compound objects into Islandora.
GNU General Public License v3.0
3 stars 12 forks source link

compatibility with drush 6- and 7+ #21

Closed GarrettArm closed 7 years ago

GarrettArm commented 7 years ago

Drush 7 reserved the keyword "target", which breaks other libraries that used "--target" as a keyword (including this library).

Following in the pattern of islandora batch and islandora batch book ingest, and in order to not break dependencies for users of drush 6 or less (who are successfully using "--target") -- This change requires users of drush 6 or less to continue their practice of using "--target", and it requires users of drush 7 or greater to use "--scan_target".

The "drush icbp --help" text matches drush version.

The function of the script is unchanged. Only this change: Drush version affects the required keyword, and changes the --help text and the example text.

drush6_success drush6_success2 drush9_success

jpeak5 commented 7 years ago

similar to https://github.com/MarcusBarnes/islandora_compound_batch/issues/19

MarcusBarnes commented 7 years ago

@jpeak5 @mjordan Thoughts? We can merge if you're happy with this approach. Thank you in advance.

mjordan commented 7 years ago

Looks OK to me, I'll just remove doing that work from work I do on #20.

jpeak5 commented 7 years ago

go for it fellas