search

MarcusBarnes / islandora_compound_batch

Provides the basic ability to batch import compound objects into Islandora.
GNU General Public License v3.0
3 stars 12 forks source link

Use value of Child relationship predicate setting rather than the default. #28

Closed MarcusBarnes closed 6 years ago

MarcusBarnes commented 6 years ago

We have been assuming the the Child relationship predicate is the default 'isConstituentOf' in the addRelationshipsForChild method https://github.com/MarcusBarnes/islandora_compound_batch/blob/0f6d81fb35cd1ddd38c16d5ed31be75753967e7f/includes/object.inc#L181. However, this value is configurable in the 'Child relationship predicate' setting on the compound object solution pack admin form admin/islandora/solution_pack_config/compound_object form. Rather than assuming that it will be the default 'isConstituentOf' (with the same caveats on that changing that setting in the compound object solution pack admin form after the fact), use the value of the 'Child relationship predicate' setting.

Thanks to @bseeger for spotting this (see https://github.com/MarcusBarnes/islandora_compound_batch/issues/27#issuecomment-403530044).

mjordan commented 6 years ago

@bseeger totally, thanks very much for pointing out this important omission.

bseeger commented 6 years ago

Thanks @mjordan and @MarcusBarnes!