search

MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Work on #371. #374

Closed mjordan closed 7 years ago

mjordan commented 7 years ago

Github issue: (#371)

What does this Pull Request do?

Changes the .ini file validation so it only checks for mappings files when checking toolchains that use the 'mods\CsvToMods' and 'mods\CdmToMods' metadata parsers.

What's new?

--cc snippets (or --c all) now only applies when the 'mods\CsvToMods' and 'mods\CdmToMods' metadata parsers are configured. This means that OAI-PMH toolchains, and toolchains that use the new Templated Metadata Parser, do not validate the metadata mappings files, which they don't use anyway.

How should this be tested?

Using the .ini files in the attached zip, run the following:

You should see no errors, and only the last command, using the issue-371-csvmods.ini file, should indicate that "Mapping snippets are OK".

Interested parties

@MarcusBarnes

issue-371.zip

MarcusBarnes commented 7 years ago

Tested using the instructions provided and the changes behave as described. Thank you @mjordan.