Closed mjordan closed 7 years ago
@mjordan I don't see the link to the attached test files mentioned in point two of the how to test section. Would you please attach the files when you get a moment? Thank you in advance.
Woops, sorry, file is now attached below.
Appears to work as expected. Thank you @mjordan.
Github issue: (#392)
What does this Pull Request do?
Changes shutdown hook scripts from running in the background to running in the foreground.
What's new?
As per the discussion in #392, we can't think of any reason to have shutdown hook scripts run as background processes. This PR replaces the code that allowed the scripts to run as a background process with a simple PHP
exec()
call.How should this be tested?
This PR requires a smoke test; there are no PHPUnit tests to cover it.
To test:
mv
) all the files in the unzipped directory starting withissue-392*
into your mik directory../mik -c issue-392.ini
. You should see the following ouput:and your /tmp/directory should contain a file
/tmp/hey.txt
.Additional Notes
We will need to update https://github.com/MarcusBarnes/mik/wiki/Shutdown-hooks.
Interested parties
@jpeak5 @MarcusBarnes